rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r348665503
##########
File path: build.gradle
##########
@@ -199,11 +200,15 @@ project(':iceberg-orc') {
exclude group: 'com.google.protobuf', module: 'protobuf-java'
exclude group: 'org.apache.hive', module: 'hive-storage-api'
}
+ compile("org.apache.hadoop:hadoop-common") {
Review comment:
I agree, Hadoop dependencies are expected to be provided at runtime, so we
don't add compile dependencies for them. This should either be `compileOnly`,
or better yet should use the pattern that other modules use:
```
compileOnly("org.apache.hadoop:hadoop-client") {
exclude group: 'org.apache.avro', module: 'avro'
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
