rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r355232866
 
 

 ##########
 File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
 ##########
 @@ -83,37 +81,13 @@ public void add(D datum) {
         batch.reset();
       }
     } catch (IOException e) {
-      throw new RuntimeException("Problem writing to ORC file " + path, e);
+      throw new RuntimeException("Problem writing to ORC file " + 
file.location(), e);
 
 Review comment:
   This should be a `RuntimeIOException`. Looks like a mistake from the initial 
commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to