rdblue commented on a change in pull request #227: ORC column map fix
URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r355233398
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -126,12 +100,14 @@ public long length() {
@Override
public List<Long> splitOffsets() {
Preconditions.checkState(isClosed, "File is not yet closed");
+ String fileLoc = file.location();
Reader reader;
try {
- reader = OrcFile.createReader(path, new OrcFile.ReaderOptions(conf));
+ reader = OrcFile.createReader(new Path(fileLoc), new
OrcFile.ReaderOptions(conf));
Review comment:
This seems expensive. Up to you whether to implement it or just let split
calculation happen without split locations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
