rdblue commented on a change in pull request #628: Implement the project and
the projectStrict in the transforms
URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r355579259
##########
File path:
api/src/test/java/org/apache/iceberg/transforms/TestDatesProjection.java
##########
@@ -77,10 +89,17 @@ public void assertProjectionInclusive(PartitionSpec spec,
UnboundPredicate<?> fi
Assert.assertEquals(predicate.op(), expectedOp);
- Literal literal = predicate.literal();
Dates transform = (Dates) spec.getFieldsBySourceId(1).get(0).transform();
- String output = transform.toHumanString((int) literal.value());
- Assert.assertEquals(expectedLiteral, output);
+ if (predicate.op() == Expression.Operation.IN || predicate.op() ==
Expression.Operation.NOT_IN) {
Review comment:
Similar to above, inclusive projection never produces NOT_IN, so this should
assert that NOT_IN is not produced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
