rdblue commented on a change in pull request #628: Implement the project and
the projectStrict in the transforms
URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r355579079
##########
File path:
api/src/test/java/org/apache/iceberg/transforms/TestDatesProjection.java
##########
@@ -50,10 +55,17 @@ public void assertProjectionStrict(PartitionSpec spec,
UnboundPredicate<?> filte
Assert.assertEquals(expectedOp, predicate.op());
- Literal literal = predicate.literal();
Dates transform = (Dates) spec.getFieldsBySourceId(1).get(0).transform();
- String output = transform.toHumanString((int) literal.value());
- Assert.assertEquals(expectedLiteral, output);
+ if (predicate.op() == Expression.Operation.IN || predicate.op() ==
Expression.Operation.NOT_IN) {
Review comment:
Strict projection never produces IN, so I think this should assert that the
projection is never an IN predicate instead of handling it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
