rdblue commented on a change in pull request #628: Implement the project and
the projectStrict in the transforms
URL: https://github.com/apache/incubator-iceberg/pull/628#discussion_r355580231
##########
File path:
api/src/test/java/org/apache/iceberg/transforms/TestDatesProjection.java
##########
@@ -94,6 +113,11 @@ public void testMonthStrictLowerBound() {
assertProjectionStrict(spec, greaterThanOrEqual("date", date),
Expression.Operation.GT, "2016-12");
assertProjectionStrict(spec, notEqual("date", date),
Expression.Operation.NOT_EQ, "2017-01");
assertProjectionStrictValue(spec, equal("date", date),
Expression.Operation.FALSE);
+
+ Integer date1 = (Integer) Literal.of("2017-12-02").to(TYPE).value();
Review comment:
Nit: how about `anotherDate` instead of `date1`? It's strange to have both
`date` and `date1` variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
