rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r364365787
##########
File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
##########
@@ -78,11 +80,27 @@ public static ManifestReader read(InputFile file) {
* @param specsById a Map from spec ID to partition spec
* @return a manifest reader
*/
+ // TODO: do we want to keep it?
public static ManifestReader read(InputFile file, Map<Integer,
PartitionSpec> specsById) {
Review comment:
What about people that are currently using this method? While we don't have
a hard requirement to keep API compatibility before we release 1.0.0, I don't
want to break people that are currently using the best practice. At Netflix, we
have people that are using the version above as well.
I would rather keep this in and create a version of `InheritableMetadata`
that fails if any metadata is missing. That way, we can keep these methods but
safely guarantee that metadata is always present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
