rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r370757449
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -144,8 +144,9 @@ private ManifestReadTask(FileIO io, FileScanTask
manifestTask, Schema schema) {
@Override
public CloseableIterable<StructLike> rows() {
+ String manifestPath = manifestTask.file().path().toString();
return CloseableIterable.transform(
-
ManifestReader.read(io.newInputFile(manifestTask.file().path().toString())).project(schema),
+
ManifestReader.readEntries(io.newInputFile(manifestPath)).project(schema),
Review comment:
What is the purpose of using `readEntries` here? Just to avoid assigning
inheritable metadata that will be ignored?
In general, I'm wondering if we need `readEntries` because I don't want
library maintainers to accidentally get manifest entries without inherited
metadata and accidentally change the inherited values. It would be easier and
more reliable to always return entries with inherited metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
