rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r371477858
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -295,7 +305,10 @@ private WriterWrapper getWriter(Object key) {
@Override
protected void cleanUncommitted(Set<ManifestFile> committed) {
cleanUncommitted(newManifests, committed);
- cleanUncommitted(addedManifests, committed);
+ if (!snapshotIdInheritanceEnabled) {
Review comment:
Okay, so I think the difference between this and the logic in
`MergingSnapshotProducer` is that this won't compact and rewrite the committed
manifests. That means that if the commit succeeded, then all the added
manifests are part of the table (so we know they will all be in the committed
list).
Here's a quick summary:
* Inheritance is enabled
* Commit succeeded - do not delete, the files are owned and part of the
table
* Commit failed - do not delete, the files are not owned
* Inheritance is not enabled - added manifests are rewritten and are owned
* Commit succeeded - run normal manifest cleanup (rely on the committed
set)
* Commit failed - run normal manifest cleanup (committed set will be empty)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
