rdblue commented on a change in pull request #750: Add time-travel methods
(asOfTime,useSnapshot) in IcebergGenerics
URL: https://github.com/apache/incubator-iceberg/pull/750#discussion_r371373953
##########
File path: data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java
##########
@@ -41,13 +42,17 @@ public static ScanBuilder read(Table table) {
public static class ScanBuilder {
private final Table table;
- private Expression where = Expressions.alwaysTrue();
- private List<String> columns = ImmutableList.of("*");
+ private TableScan tableScan;
+ private final Expression defaultWhere = Expressions.alwaysTrue();
+ private final List<String> defaultColumns = ImmutableList.of("*");
private boolean reuseContainers = false;
- private boolean caseSensitive = true;
+ private final boolean defaultCaseSensitive = true;
public ScanBuilder(Table table) {
this.table = table;
+ this.tableScan = table.newScan()
+ .select(this.defaultColumns)
+ .caseSensitive(this.defaultCaseSensitive);
Review comment:
Instead of having defaults here as well as in the table scan, this should
just create a new scan and rely on its defaults.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
