rdblue commented on a change in pull request #750: Add time-travel methods
(asOfTime,useSnapshot) in IcebergGenerics
URL: https://github.com/apache/incubator-iceberg/pull/750#discussion_r371375805
##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -114,53 +122,105 @@ public void createTables() throws IOException {
Record record = GenericRecord.create(SCHEMA);
- this.file1Records = Lists.newArrayList(
+ this.file1FirstSnapshotRecords = Lists.newArrayList(
+ record.copy(ImmutableMap.of("id", 4L, "data", "obscure")),
Review comment:
Continuation indents should be 2 indents = 4 spaces, not 8 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
