rdsr commented on a change in pull request #750: Add time-travel methods
(asOfTime,useSnapshot) in IcebergGenerics
URL: https://github.com/apache/incubator-iceberg/pull/750#discussion_r371424034
##########
File path: data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java
##########
@@ -56,27 +61,33 @@ public ScanBuilder reuseContainers() {
}
public ScanBuilder where(Expression rowFilter) {
- this.where = Expressions.and(where, rowFilter);
+ this.tableScan = this.tableScan.filter(Expressions.and(defaultWhere,
rowFilter));
Review comment:
Seems like we can either keeping refining the `tableScan` obj in each of the
builder methods in which case we might not need to have instance fields like
`where`, `caseSensitive` etc and we should delete them where possible. Or we
create the `tablescan` once in the `build` method in which case we will need to
keep our own instance fields, but then we should remove the tablescan refine
from each fo the build methods. Either approach is fine by me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
