rdblue commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r371385370
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -122,11 +122,7 @@ public static Expression convert(Filter filter) {
case IN:
In inFilter = (In) filter;
- Expression in = alwaysFalse();
- for (Object value : inFilter.values()) {
- in = or(in, equal(inFilter.attribute(), convertLiteral(value)));
- }
- return in;
+ return in(inFilter.attribute(), inFilter.values());
Review comment:
Now that I read this a second time, I think you may be talking about when
Spark passes a null value here?
I agree that's a problem. This should detect and filter out null values
because Iceberg's `in` expression will throw an exception if it encounters
them. If there is a null, then this can return `or(isNull(attr), in(attr,
nonNullValues))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
