aokolnychyi commented on a change in pull request #749: Convert Spark In filter
to iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r371641202
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -122,11 +122,7 @@ public static Expression convert(Filter filter) {
case IN:
In inFilter = (In) filter;
- Expression in = alwaysFalse();
- for (Object value : inFilter.values()) {
- in = or(in, equal(inFilter.attribute(), convertLiteral(value)));
- }
- return in;
+ return in(inFilter.attribute(), inFilter.values());
Review comment:
Actually, null is never equal to null.
```
null IN (1, 2, 3) -> null
null IN (1, 2, 3, null) -> null
1 IN (1, 2, 3) -> true
1 IN (1, 2, 3, null) -> true
-1 IN (1, 2, 3) -> false
-1 IN (1, 2, 3, null) -> null
```
I wonder if we can simply filter out null values to avoid the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
