jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373880462
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##########
@@ -543,11 +579,11 @@ private File buildPartitionedTable(String desc,
PartitionSpec spec, String udf,
private List<Record> testRecords(org.apache.avro.Schema avroSchema) {
return Lists.newArrayList(
- record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294658+00:00"),
"junction"),
+ record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294+00:00"),
"junction"),
Review comment:
@rdblue It is because `java.sql.Timestamp` constructor uses a milliseconds
time value.
There is a deprecated `java.sql.Timestamp` constructor to use year, month,
date, hour, minute, second, and nano. But we also need take care of timezone
issue (java timestamp is always UTC).
So to avoid using deprecated method and make the test straightforward, I
just update two records to be millisecond scale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
