rdblue commented on a change in pull request #750: Add time-travel methods
(asOfTime,useSnapshot) in IcebergGenerics
URL: https://github.com/apache/incubator-iceberg/pull/750#discussion_r372510717
##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -279,31 +323,107 @@ public void testProjectWithMissingFilterColumn() {
Sets.newHashSet(transform(results, record ->
record.getField("data").toString())));
}
- private InputFile writeFile(String location, String filename, List<Record>
records) throws IOException {
+ @Test
+ public void testUseSnapshot() throws IOException {
+ overwriteExistingData();
+ Iterable<Record> results = IcebergGenerics.read(sharedTable)
+ .useSnapshot(/* first snapshot */
sharedTable.history().get(1).snapshotId())
+ .build();
+
+ Set<Record> expected = Sets.newHashSet();
+ expected.addAll(file1FirstSnapshotRecords);
+ expected.addAll(file2FirstSnapshotRecords);
+ expected.addAll(file3FirstSnapshotRecords);
+
+ Set<Record> records = Sets.newHashSet(results);
+ Assert.assertEquals("Should produce correct number of records",
+ expected.size(), records.size());
+ Assert.assertEquals("Record set should match",
+ Sets.newHashSet(expected), records);
+ Assert.assertNotNull(Iterables.get(records, 0).getField("id"));
+ Assert.assertNotNull(Iterables.get(records, 0).getField("data"));
+ }
+
+ @Test
+ public void testAsOfTime() throws IOException {
+ overwriteExistingData();
+ Iterable<Record> results = IcebergGenerics.read(sharedTable)
+ .asOfTime(/* timestamp first snapshot */
sharedTable.history().get(2).timestampMillis())
+ .build();
+
+ Set<Record> expected = Sets.newHashSet();
+ expected.addAll(file1SecondSnapshotRecords);
+ expected.addAll(file2SecondSnapshotRecords);
+ expected.addAll(file3SecondSnapshotRecords);
+
+ Set<Record> records = Sets.newHashSet(results);
+ Assert.assertEquals("Should produce correct number of records",
+ expected.size(), records.size());
+ Assert.assertEquals("Record set should match",
+ Sets.newHashSet(expected), records);
+ Assert.assertNotNull(Iterables.get(records, 0).getField("id"));
+ Assert.assertNotNull(Iterables.get(records, 0).getField("data"));
+ }
+
+ @Test
+ public void testUnknownSnapshotId() {
+ Long minSnapshotId = sharedTable.history().stream().map(h ->
h.snapshotId()).min(Long::compareTo).get();
+
+ IcebergGenerics.ScanBuilder scanBuilder =
IcebergGenerics.read(sharedTable);
+
+ AssertHelpers.assertThrows("Should fail on unknown snapshot id",
+ IllegalArgumentException.class,
+ "Cannot find snapshot with ID ",
+ () -> scanBuilder.useSnapshot(/* unknown snapshot id */ minSnapshotId
- 1));
+ }
+
+ @Test
+ public void testAsOfTimeOlderThanFirstSnapshot() {
+ IcebergGenerics.ScanBuilder scanBuilder =
IcebergGenerics.read(sharedTable);
+
+ AssertHelpers.assertThrows("Should fail on timestamp sooner than first
write",
+ IllegalArgumentException.class,
+ "Cannot find a snapshot older than ",
+ () -> scanBuilder.asOfTime(/* older than first snapshot */
sharedTable.history().get(0).timestampMillis() - 1));
+ }
+
+ private DataFile writeFile(String location, String filename, List<Record>
records) throws IOException {
Path path = new Path(location, filename);
FileFormat fileFormat = FileFormat.fromFileName(filename);
Preconditions.checkNotNull(fileFormat, "Cannot determine format for file:
%s", filename);
switch (fileFormat) {
case AVRO:
- try (FileAppender<Record> appender = Avro.write(fromPath(path, CONF))
+ FileAppender avroAppender = Avro.write(fromPath(path, CONF))
.schema(SCHEMA)
.createWriterFunc(DataWriter::create)
.named(fileFormat.name())
- .build()) {
- appender.addAll(records);
+ .build();
+ try {
+ avroAppender.addAll(records);
+ } finally {
+ avroAppender.close();
}
- return HadoopInputFile.fromPath(path, CONF);
+ return DataFiles.builder(PartitionSpec.unpartitioned())
+ .withInputFile(HadoopInputFile.fromPath(path, CONF))
+ .withMetrics(avroAppender.metrics())
+ .build();
case PARQUET:
- try (FileAppender<Record> appender = Parquet.write(fromPath(path,
CONF))
+ FileAppender<Record> orcAppender = Parquet.write(fromPath(path, CONF))
Review comment:
Typo: should be `parquetAppender`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
