rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r373601362
##########
File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala
##########
@@ -420,7 +420,7 @@ object SparkTableUtil {
private def buildManifest(
conf: SerializableConfiguration,
spec: PartitionSpec,
- basePath: String): Iterator[SparkDataFile] => Iterator[Manifest] = {
files =>
+ basePath: String): Iterator[SparkDataFile] => Iterator[ManifestFile] = {
files =>
Review comment:
I'm not sure whether it's a good idea to make an interface `Serializable`.
I'll have to think about that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
