rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r373279470
##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntry.java
##########
@@ -49,7 +50,7 @@ public int id() {
private final org.apache.avro.Schema schema;
private Status status = Status.EXISTING;
- private long snapshotId = 0L;
+ private Long snapshotId = null;
Review comment:
Just to make sure: have you checked that older readers can read files
produced with optional instead of required snapshotIds?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
