rdblue commented on a change in pull request #675: Inherit snapshot ids for
manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r373282356
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -44,6 +44,9 @@ private TableProperties() {}
public static final String MANIFEST_MERGE_ENABLED =
"commit.manifest-merge.enabled";
public static final boolean MANIFEST_MERGE_ENABLED_DEFAULT = true;
+ public static final String SNAPSHOT_ID_INHERITANCE_ENABLED =
"commit.snapshot-id-inheritance.enabled";
Review comment:
Minor: I would rather have a different prefix for feature flags. This does
affect commit behavior, but this property doesn't signal that it breaks
forward-compatibility to turn it on.
What about using `compatibility` as the initial prefix? Then we would have
`compatibility.snapshot-id-inheritance.enabled`. I think that signals clearly
that it affects compatibility and you should look it up in documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
