rdsr commented on a change in pull request #315: Incremental processing
implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373655199
##########
File path: core/src/main/java/org/apache/iceberg/DataTableScan.java
##########
@@ -58,6 +52,23 @@ protected DataTableScan(TableOperations ops, Table table,
Long snapshotId, Schem
super(ops, table, snapshotId, schema, rowFilter, caseSensitive, colStats,
selectedColumns, options);
}
+ @Override
+ public TableScan appendsBetween(Long fromSnapshotId, Long toSnapshotId) {
+ final Long scanSnapshotId = snapshotId();
+ Preconditions.checkState(scanSnapshotId == null,
+ "Cannot enable incremental scan, scan-snapshot set to id=%s",
scanSnapshotId);
+ return new IncrementalDataTableScan(
+ tableOps(), table(), schema(), filter(), isCaseSensitive(),
colStats(), selectedColumns(), options(),
+ fromSnapshotId, toSnapshotId);
+ }
+
+ @Override
+ public TableScan appendsAfter(Long fromSnapshotId) {
+ final Snapshot currentSnapshot = table().currentSnapshot();
Review comment:
I have to fix my ide 🤷♂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
