rdsr commented on a change in pull request #315: Incremental processing implementation URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373761074
########## File path: core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import com.google.common.base.Preconditions; +import com.google.common.base.Predicate; +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.Iterables; +import com.google.common.collect.Lists; +import java.util.Collection; +import java.util.List; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.util.SnapshotUtil; + +class IncrementalDataTableScan extends DataTableScan { + private Long fromSnapshotId; + private Long toSnapshotId; + + IncrementalDataTableScan(TableOperations ops, Table table, Schema schema, + Expression rowFilter, boolean caseSensitive, boolean colStats, + Collection<String> selectedColumns, ImmutableMap<String, String> options, + Long fromSnapshotId, Long toSnapshotId) { + super(ops, table, null, schema, rowFilter, caseSensitive, colStats, selectedColumns, options); + Preconditions.checkArgument(fromSnapshotId != toSnapshotId, "fromSnapshotId and toSnapshotId cannot be the same"); + this.fromSnapshotId = fromSnapshotId; + this.toSnapshotId = toSnapshotId; + } + + @Override + public TableScan asOfTime(long timestampMillis) { + throw new UnsupportedOperationException("asOfTime() is not supported in IncrementalScan"); + } + + @Override + public TableScan useSnapshot(long scanSnapshotId) { + throw new UnsupportedOperationException("useSnapshot() is not supported in incremental scan"); + } + + @Override + public TableScan appendsBetween(Long newFromSnapshotId, Long newToSnapshotId) { + Preconditions.checkArgument( + table().snapshot(newFromSnapshotId) != null, "fromSnapshotId: %s does not exist", newFromSnapshotId); + Preconditions.checkArgument( + table().snapshot(newToSnapshotId) != null, "toSnapshotId: %s does not exist", newToSnapshotId); + return new IncrementalDataTableScan( + tableOps(), table(), schema(), filter(), isCaseSensitive(), colStats(), selectedColumns(), options(), + newFromSnapshotId, newToSnapshotId); + } + + @Override + public TableScan appendsAfter(Long newFromSnapshotId) { + final Snapshot currentSnapshot = table().currentSnapshot(); + Preconditions.checkState(currentSnapshot != null, "Current snapshot is null"); + return appendsBetween(newFromSnapshotId, currentSnapshot.snapshotId()); + } + + @Override + public CloseableIterable<FileScanTask> planFiles() { + //TODO publish an incremental appends scan event + List<Snapshot> snapshots = snapshotsWithin(table(), fromSnapshotId, toSnapshotId); + Iterable<CloseableIterable<FileScanTask>> files = Iterables.transform(snapshots, this::planFiles); + return CloseableIterable.concat(files); + } + + private CloseableIterable<FileScanTask> planFiles(Snapshot snapshot) { + Predicate<ManifestFile> matchingManifests = manifest -> manifest.snapshotId() == snapshot.snapshotId(); + + Predicate<ManifestEntry> matchingManifestEntries = + manifestEntry -> + manifestEntry.snapshotId() == snapshot.snapshotId() && + manifestEntry.status() == ManifestEntry.Status.ADDED; + + return planFiles( + tableOps(), snapshot, filter(), isCaseSensitive(), colStats(), matchingManifests, matchingManifestEntries); + } + + @Override + @SuppressWarnings("checkstyle:HiddenField") + protected TableScan newRefinedScan( + TableOperations ops, Table table, Long snapshotId, Schema schema, Expression rowFilter, + boolean caseSensitive, boolean colStats, Collection<String> selectedColumns, + ImmutableMap<String, String> options) { + return new IncrementalDataTableScan( + ops, table, schema, rowFilter, caseSensitive, colStats, selectedColumns, options, + fromSnapshotId, toSnapshotId); + } + + private static List<Snapshot> snapshotsWithin(Table table, long fromSnapshotId, long toSnapshotId) { + List<Long> snapshotIds = SnapshotUtil.currentAncestors(table); + int toSnapshotIdIndex = snapshotIds.indexOf(toSnapshotId); + Preconditions.checkState(toSnapshotIdIndex != -1, "Undefined state: toSnapshotId: %s not found", toSnapshotId); Review comment: Yes. I'll remove ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
