rdsr commented on a change in pull request #315: Incremental processing 
implementation
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r373885093
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
 ##########
 @@ -42,6 +42,16 @@ private SnapshotUtil() {
     return ancestorIds(table.currentSnapshot(), table::snapshot);
   }
 
+  /**
+   * @return List of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
+   * This method assumes that fromSnapshotId is an ancestor of toSnapshotId
 
 Review comment:
   Yes. It will be in the follow-up

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to