jun-he commented on a change in pull request #749: Convert Spark In filter to
iceberg IN Expression
URL: https://github.com/apache/incubator-iceberg/pull/749#discussion_r373900954
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##########
@@ -543,11 +579,11 @@ private File buildPartitionedTable(String desc,
PartitionSpec spec, String udf,
private List<Record> testRecords(org.apache.avro.Schema avroSchema) {
return Lists.newArrayList(
- record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294658+00:00"),
"junction"),
+ record(avroSchema, 0L, timestamp("2017-12-22T09:20:44.294+00:00"),
"junction"),
Review comment:
The test fails because those partitions picked in the tests have only one
value (equals the lower and higher bound) so the Timestamp must exactly match.
To avoid change those values, I will update the test to use the partition of
`2017-12-21T15`, which contains two records. So any Timestamp between them will
match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
