rdblue commented on a change in pull request #784: Allow caller to construct
HadoopInputFile and HadoopOutputFile using an existing instance of FileSystem
object.
URL: https://github.com/apache/incubator-iceberg/pull/784#discussion_r377400690
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopInputFile.java
##########
@@ -133,7 +143,7 @@ public SeekableInputStream newStream() {
}
public Configuration getConf() {
- return conf;
+ return fs.getConf();
Review comment:
This needs to return the `Configuration` that was passed in when creating
the `HadoopInputFile`, if there was one. The file system's `Configuration` may
not contain the same configuration properties as the one that was passed in,
and this `Configuration` is needed in some paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
