rdblue commented on a change in pull request #784: Allow caller to construct HadoopInputFile and HadoopOutputFile using an existing instance of FileSystem object. URL: https://github.com/apache/incubator-iceberg/pull/784#discussion_r377401371
########## File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopOutputFile.java ########## @@ -73,7 +87,7 @@ public Path getPath() { } public Configuration getConf() { - return conf; + return fs.getConf(); Review comment: This also needs to return the `Configuration` that was used to create the output file, if there was one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org