rdblue commented on a change in pull request #784: Allow caller to construct
HadoopInputFile and HadoopOutputFile using an existing instance of FileSystem
object.
URL: https://github.com/apache/incubator-iceberg/pull/784#discussion_r377962177
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopInputFile.java
##########
@@ -133,7 +143,7 @@ public SeekableInputStream newStream() {
}
public Configuration getConf() {
- return conf;
+ return fs.getConf();
Review comment:
I don't think we want to add complexity to how `Configuration` objects are
handled. A `Configuration` is used to instantiate a catalog, and it gets passed
down to `FileIO` from there. We don't need to be able to change that
configuration, we just need to make sure the one passed to create the catalog
is used by parts like ORC that currently use a `Configuration`.
And if a `Configuration` is not passed, it is fine to use `new
Configuration()` or the config from a file system that was passed. We don't
make guarantees in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
