rdsr edited a comment on issue #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#issuecomment-585294292 >However, another approach can be to just store the timestamp forced to the UTC timezone as a "Timestamp Instant" so that ORC does not apply any offset calculations on it and let Iceberg handle the read to LocalDateTime (I believe this is what we do for Avro Generics today). I think we should handle both `Timestamp` and `TimestampTz` on the read side, since in the future Iceberg could support reading ORC data not written by Iceberg orc writers, so there could be data of `Timestamp` type on disc. When writing from Iceberg, I don't see a problem with always using the `TimestampTz` converter
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
