edgarRd commented on a change in pull request #778: ORC: Implement
TestGenericData and fix reader and writer issues
URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r378958469
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java
##########
@@ -70,20 +70,19 @@ public TypeDescription type() {
private static final String ICEBERG_ID_ATTRIBUTE = "iceberg.id";
private static final String ICEBERG_REQUIRED_ATTRIBUTE = "iceberg.required";
- private static final String ICEBERG_BINARY_TYPE_ATTRIBUTE =
"iceberg.binary-type";
- private static final String ICEBERG_INTEGER_TYPE_ATTRIBUTE =
"iceberg.integer-type";
- private static final String ICEBERG_FIELD_LENGTH = "iceberg.length";
+ public static final String ICEBERG_BINARY_TYPE_ATTRIBUTE =
"iceberg.binary-type";
+ public static final String ICEBERG_LONG_TYPE_ATTRIBUTE = "iceberg.long-type";
+ public static final String ICEBERG_FIELD_LENGTH = "iceberg.length";
private static final ImmutableMap<Type.TypeID, TypeDescription.Category>
TYPE_MAPPING =
ImmutableMap.<Type.TypeID, TypeDescription.Category>builder()
.put(Type.TypeID.BOOLEAN, TypeDescription.Category.BOOLEAN)
.put(Type.TypeID.INTEGER, TypeDescription.Category.INT)
- .put(Type.TypeID.TIME, TypeDescription.Category.INT)
.put(Type.TypeID.LONG, TypeDescription.Category.LONG)
+ .put(Type.TypeID.TIME, TypeDescription.Category.LONG)
.put(Type.TypeID.FLOAT, TypeDescription.Category.FLOAT)
.put(Type.TypeID.DOUBLE, TypeDescription.Category.DOUBLE)
.put(Type.TypeID.DATE, TypeDescription.Category.DATE)
- .put(Type.TypeID.TIMESTAMP, TypeDescription.Category.TIMESTAMP)
Review comment:
What's `Type.TypeID.TIMESTAMP` now mapping to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
