rdblue commented on a change in pull request #830: Support name mapping
resolution for parquet
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r404455014
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -393,6 +395,11 @@ public ReadBuilder recordsPerBatch(int numRowsPerBatch) {
return this;
}
+ public ReadBuilder withNameMapping(NameMapping newNameMapping) {
Review comment:
This is called `nameMapping` in the Avro API. I think I prefer this name,
but we should be consistent and either change that one or use the same name
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
