rdblue commented on a change in pull request #830: Support name mapping
resolution for parquet
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r404459140
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetReadSupport.java
##########
@@ -57,7 +58,7 @@ public ReadContext init(Configuration configuration,
Map<String, String> keyValu
MessageType projection = ParquetSchemaUtil.hasIds(fileSchema) ?
ParquetSchemaUtil.pruneColumns(fileSchema, expectedSchema) :
- ParquetSchemaUtil.pruneColumnsFallback(fileSchema, expectedSchema);
+ ParquetSchemaUtil.pruneColumnsByName(fileSchema, expectedSchema,
MappingUtil.create(expectedSchema));
Review comment:
This should not replace the existing fallback strategy. If the mapping is
present, it should be used. Otherwise, the existing position-based fallback
strategy should be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
