rdblue commented on a change in pull request #830: Support name mapping
resolution for parquet
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r404458923
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
##########
@@ -64,8 +68,14 @@ public ParquetMetricsRowGroupFilter(Schema schema,
Expression unbound) {
public ParquetMetricsRowGroupFilter(Schema schema, Expression unbound,
boolean caseSensitive) {
this.schema = schema;
- StructType struct = schema.asStruct();
- this.expr = Binder.bind(struct, Expressions.rewriteNot(unbound),
caseSensitive);
+ this.expr = unbound;
+ this.caseSensitive = caseSensitive;
+ }
+
+
+ public ParquetMetricsRowGroupFilter withNameMapping(NameMapping
newNameMapping) {
+ this.nameMapping = newNameMapping;
+ return this;
Review comment:
This file also should not be modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
