jun-he commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r405309135
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -350,7 +354,8 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
- public TableMetadata updatePartitionSpec(PartitionSpec newPartitionSpec) {
+ // newPartitionSpec's partition field IDs should have already been refreshed
Review comment:
This comment is about the input parameter `PartitionSpec newPartitionSpec`,
whose field ids has to be recomputed so that `freshSpec` does not need to take
care of that extra work.
Updated this comment to make it clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
