rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r403269235
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -350,7 +354,8 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
- public TableMetadata updatePartitionSpec(PartitionSpec newPartitionSpec) {
+ // newPartitionSpec's partition field IDs should have already been refreshed
+ TableMetadata updatePartitionSpec(PartitionSpec newPartitionSpec) {
Review comment:
These should still be public like the other methods. Instead of making them
private, they should sanity check the spec:
* For a v1 table, field IDs should be assigned from 1000 and should have no
gaps
* For a v2 table or newer, all fields should have IDs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
