rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r403267125
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -350,7 +354,8 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
- public TableMetadata updatePartitionSpec(PartitionSpec newPartitionSpec) {
+ // newPartitionSpec's partition field IDs should have already been refreshed
Review comment:
Spec field IDs don't need to be refreshed. `freshSpec` is used for two
things:
1. If schema IDs are reassigned, then it rebuilds the spec to with the new
schema
2. It sets the spec's ID to the one assigned in this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
