rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r406889223
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -352,6 +355,7 @@ public TableMetadata updateSchema(Schema newSchema, int
newLastColumnId) {
currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
+ // Input newPartitionSpec's partition field IDs should have already been
recomputed
Review comment:
#903 added `formatVersion` to metadata, so now we can add a validation here
when the table is v1 that the spec IDs are assigned as expected:
```
ValidationException.check(formatVersion > 1 || hasSequentialIds(spec),
"Spec does not use sequential IDs that are required in v1: %s", spec);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
