jun-he commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r408580753
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -487,8 +491,9 @@ public TableMetadata removeSnapshotLogEntries(Set<Long>
snapshotIds) {
currentSnapshotId, snapshots, newSnapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
- public TableMetadata buildReplacement(Schema updatedSchema, PartitionSpec
updatedPartitionSpec,
- Map<String, String> updatedProperties)
{
+ // updatedPartitionSpec's partition field IDs should have already been
refreshed
+ TableMetadata buildReplacement(Schema updatedSchema, PartitionSpec
updatedPartitionSpec,
Review comment:
@rdblue thanks for the comment.
I am thinking to expose those functionalities (`PartitionSpecUpdate` or
`buildReplacement`) over `Table` and `UpdatePartitionSpec` public interface. So
we can limit their access to be package/default level.
I will change them back to public in the PR and we may limit their access in
the partition spec evolution PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
