rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r406889474
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -487,8 +491,9 @@ public TableMetadata removeSnapshotLogEntries(Set<Long>
snapshotIds) {
currentSnapshotId, snapshots, newSnapshotLog, addPreviousFile(file,
lastUpdatedMillis));
}
- public TableMetadata buildReplacement(Schema updatedSchema, PartitionSpec
updatedPartitionSpec,
- Map<String, String> updatedProperties)
{
+ // updatedPartitionSpec's partition field IDs should have already been
refreshed
+ TableMetadata buildReplacement(Schema updatedSchema, PartitionSpec
updatedPartitionSpec,
+ Map<String, String> updatedProperties) {
Review comment:
We should add a validation for format v1 here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
