rdblue commented on a change in pull request #931: Add residual evaluation for
MR reader
URL: https://github.com/apache/incubator-iceberg/pull/931#discussion_r409700702
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -394,8 +378,14 @@ public void close() throws IOException {
String.format("Cannot read %s file: %s", file.format().name(),
file.path()));
}
currentCloseable = iterable;
- //TODO: Apply residual filtering before returning the iterator
- return iterable.iterator();
+ boolean applyResidualFiltering =
!context.getConfiguration().getBoolean(SKIP_RESIDUAL_FILTERING, false);
+ if (applyResidualFiltering && currentTask.residual() != null &&
Review comment:
I agree with this. And we can also shorten the boolean variable name to
`applyResidual`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
