rdblue commented on a change in pull request #931: Add residual evaluation for
MR reader
URL: https://github.com/apache/incubator-iceberg/pull/931#discussion_r410479574
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -199,11 +200,10 @@ public ConfigBuilder usePigTuples() {
/**
* Compute platforms pass down filters to data sources. If the data source
cannot apply some filters, or only
* partially applies the filter, it will return the residual filter back.
If the platform can correctly apply
- * the residual filters, then it should call this api. Otherwise the
current api will throw an exception if the
- * passed in filter is not completely satisfied.
+ * the residual filters, then it should call this api to enable the
residual filtering.
*/
- public ConfigBuilder skipResidualFiltering() {
- conf.setBoolean(SKIP_RESIDUAL_FILTERING, true);
+ public ConfigBuilder enableResidualFiltering() {
+ conf.setBoolean(SKIP_RESIDUAL_FILTERING, false);
Review comment:
-1 until this is reverted.
The InputFormat should default to applying residuals because that is what
users expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
