chenjunjiedada commented on a change in pull request #931: Add residual
evaluation for MR reader
URL: https://github.com/apache/incubator-iceberg/pull/931#discussion_r409942095
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -259,18 +255,6 @@ public ConfigBuilder skipResidualFiltering() {
return splits;
}
- private static void checkResiduals(CombinedScanTask task) {
- task.files().forEach(fileScanTask -> {
Review comment:
If the `skipResidualFiltering` is true, we skip the evaluation and thus
don't need `checkResiduals`. How about we set `skipResidualFiltering` to true
as default? Or maybe change it to `enableResidualFiltering` and set default
value to false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
