chenjunjiedada commented on a change in pull request #931: Add residual
evaluation for MR reader
URL: https://github.com/apache/incubator-iceberg/pull/931#discussion_r410549476
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -316,6 +318,7 @@ public boolean nextKeyValue() throws IOException {
currentCloseable.close();
currentIterator = open(tasks.next());
} else {
+ currentCloseable.close();
Review comment:
It causes unclosed input stream issue if we don't close here, looks like mr
framework doesn't call the final close method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
