MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1262110720
##########
build.gradle:
##########
@@ -461,46 +455,49 @@ project(':iceberg-aws') {
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(':iceberg-core')
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
- implementation "com.github.ben-manes.caffeine:caffeine"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
+ implementation libs.caffeine
+ implementation platform(libs.jackson.bom)
Review Comment:
This approach using bom was suggested by @snazy in
https://github.com/apache/iceberg/pull/7694#discussion_r1227938340 &
https://github.com/apache/iceberg/pull/7694#discussion_r1227943762
which actually has its own advantages
##########
build.gradle:
##########
@@ -461,46 +455,49 @@ project(':iceberg-aws') {
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(':iceberg-core')
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
- implementation "com.github.ben-manes.caffeine:caffeine"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
+ implementation libs.caffeine
+ implementation platform(libs.jackson.bom)
implementation "com.fasterxml.jackson.core:jackson-databind"
implementation "com.fasterxml.jackson.core:jackson-core"
- compileOnly 'software.amazon.awssdk:url-connection-client'
- compileOnly 'software.amazon.awssdk:apache-client'
- compileOnly 'software.amazon.awssdk:auth'
- compileOnly 'software.amazon.awssdk:s3'
- compileOnly 'software.amazon.awssdk:kms'
- compileOnly 'software.amazon.awssdk:glue'
- compileOnly 'software.amazon.awssdk:sts'
- compileOnly 'software.amazon.awssdk:dynamodb'
- compileOnly 'software.amazon.awssdk:lakeformation'
-
- compileOnly("org.apache.hadoop:hadoop-common") {
+ compileOnly(platform(libs.awssdk.bom))
Review Comment:
This approach using bom was suggested by @snazy in
https://github.com/apache/iceberg/pull/7694#discussion_r1227938340 &
https://github.com/apache/iceberg/pull/7694#discussion_r1227943762
which actually has its own advantages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
