MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1272977201
##########
build.gradle:
##########
@@ -344,33 +335,33 @@ project(':iceberg-core') {
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
- implementation("org.apache.avro:avro") {
+ implementation(libs.avro.avro) {
exclude group: 'org.tukaani' // xz compression is not supported
}
- implementation 'io.airlift:aircompressor'
- implementation 'org.apache.httpcomponents.client5:httpclient5'
- implementation "com.fasterxml.jackson.core:jackson-databind"
+ implementation libs.aircompressor
+ implementation libs.httpcomponents.httpclient5
+ implementation platform(libs.jackson.bom)
Review Comment:
Added it back, I think I removed it by accident, thanks!
Though all the check still passed somehow even without it 🤷
##########
build.gradle:
##########
@@ -344,33 +335,33 @@ project(':iceberg-core') {
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
- implementation("org.apache.avro:avro") {
+ implementation(libs.avro.avro) {
exclude group: 'org.tukaani' // xz compression is not supported
}
- implementation 'io.airlift:aircompressor'
- implementation 'org.apache.httpcomponents.client5:httpclient5'
- implementation "com.fasterxml.jackson.core:jackson-databind"
+ implementation libs.aircompressor
+ implementation libs.httpcomponents.httpclient5
+ implementation platform(libs.jackson.bom)
Review Comment:
Added it back, I think I removed it by accident, thanks!
Though all the check still passed somehow even without it 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
