MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1262114490
##########
build.gradle:
##########
@@ -539,13 +536,14 @@ project(':iceberg-delta-lake') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
implementation project(':iceberg-parquet')
+ implementation platform(libs.jackson.bom)
implementation "com.fasterxml.jackson.core:jackson-databind"
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
- compileOnly "io.delta:delta-standalone_${scalaVersion}"
+ compileOnly
"io.delta:delta-standalone_${scalaVersion}:${libs.versions.deltaStandalone.get()}"
Review Comment:
Because it's a dynamic dependency that include scalaVersion, it seem that
there is no way to express it purely using versionCaralog using nice looking
path like libs.delta.standalone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
