rdblue commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1264197758
##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/iceberg/spark/extensions/IcebergSparkSessionExtensions.scala:
##########
@@ -51,13 +51,13 @@ class IcebergSparkSessionExtensions extends
(SparkSessionExtensions => Unit) {
extensions.injectResolutionRule { _ => ProcedureArgumentCoercion }
extensions.injectResolutionRule { _ => AlignRowLevelCommandAssignments }
extensions.injectResolutionRule { _ => RewriteUpdateTable }
- extensions.injectResolutionRule { _ => RewriteMergeIntoTable }
extensions.injectCheckRule { _ => MergeIntoIcebergTableResolutionCheck }
extensions.injectCheckRule { _ => AlignedRowLevelIcebergCommandCheck }
// optimizer extensions
extensions.injectOptimizerRule { _ =>
ExtendedSimplifyConditionalsInPredicate }
extensions.injectOptimizerRule { _ =>
ExtendedReplaceNullWithFalseInPredicate }
+ extensions.injectOptimizerRule { spark => RewriteStaticInvoke(spark) }
Review Comment:
Can we do this in a separate PR? I don't think the basic support for
functions should include this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]