ConeyLiu commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1260837678
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -302,10 +326,25 @@ private static <T> T childAtIndex(Predicate predicate,
int index) {
return (T) predicate.children()[index];
}
+ private static boolean
couldConvert(org.apache.spark.sql.connector.expressions.Expression expr) {
Review Comment:
changed to `canConvertToTerm `
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -59,6 +68,9 @@
public class SparkV2Filters {
+ private static final Set<String> FUNCTIONS_SUPPORT_CONVERT =
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
