ConeyLiu commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1260837191
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -302,10 +354,25 @@ private static <T> T childAtIndex(Predicate predicate,
int index) {
return (T) predicate.children()[index];
}
+ private static boolean
couldConvert(org.apache.spark.sql.connector.expressions.Expression expr) {
+ return isRef(expr) || isSystemFunc(expr);
+ }
+
private static boolean
isRef(org.apache.spark.sql.connector.expressions.Expression expr) {
return expr instanceof NamedReference;
}
+ private static boolean
isSystemFunc(org.apache.spark.sql.connector.expressions.Expression expr) {
+ if (expr instanceof UserDefinedScalarFunc) {
+ UserDefinedScalarFunc udf = (UserDefinedScalarFunc) expr;
+ return udf.canonicalName().startsWith("iceberg")
Review Comment:
> It may be better to have a set of supported functions that uses just the
canonicalName.
There are some `canonicalName` that are not constants, for example:
```
@Override
public String canonicalName() {
return String.format("iceberg.bucket(%s)", sqlType.catalogString());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
