rdblue commented on a change in pull request #936:
URL: https://github.com/apache/incubator-iceberg/pull/936#discussion_r412380264
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFiles.java
##########
@@ -73,8 +73,8 @@ public static ManifestReader read(ManifestFile manifest,
FileIO io, Map<Integer,
* @return a manifest writer
*/
public static ManifestWriter write(PartitionSpec spec, OutputFile
outputFile) {
- // always use a v1 writer for appended manifests because sequence number
must be inherited
- return write(1, spec, outputFile, null);
+ // always use a v2 writer to preserve sequence numbers, but use null for
sequence number so appends inherit
Review comment:
This is the constructor used to create an append or rewritten manifest,
so this makes the manifests that are passed into `FastAppend`, `MergeAppend`,
and `RewriteManifests` support sequence numbers. It is needed for the last
case: when rewriting a manifest for a v2 table, we need to preserve sequence
numbers.
This works for v1 because v1 tables will ignore the new fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
