rdblue commented on a change in pull request #936:
URL: https://github.com/apache/incubator-iceberg/pull/936#discussion_r412429378
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -52,6 +52,14 @@ public static TableMetadata newTableMetadata(Schema schema,
PartitionSpec spec,
String location,
Map<String, String> properties)
{
+ return newTableMetadata(schema, spec, location, properties,
DEFAULT_TABLE_FORMAT_VERSION);
+ }
+
+ static TableMetadata newTableMetadata(Schema schema,
+ PartitionSpec spec,
+ String location,
+ Map<String, String> properties,
+ int formatVersion) {
Review comment:
We don't use that annotation elsewhere and I'm reluctant to start
because it increases our dependence on guava. It is also likely that we will
open this up later, so I don't think we need to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
