rdblue commented on a change in pull request #936:
URL: https://github.com/apache/incubator-iceberg/pull/936#discussion_r412434201
##########
File path: core/src/main/java/org/apache/iceberg/V2Metadata.java
##########
@@ -243,11 +243,11 @@ static Schema wrapFileSchema(Types.StructType fileSchema)
{
static class IndexedManifestEntry implements ManifestEntry, IndexedRecord {
private final org.apache.avro.Schema avroSchema;
- private final long commitSnapshotId;
+ private final Long commitSnapshotId;
Review comment:
Isn't this okay because it will unbox the values first? Using `equals`
would duplicate the null checks, I thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
